[PATCH] D85433: [compiler-rt][ubsan][test] XFAIL TypeCheck/misaligned.cpp on Sparc

[Rainer Orth via Phabricator via llvm-commits]

ro added a comment.

In D85433#2201003 <https://reviews.llvm.org/D85433#2201003>, @vsk wrote:

> As an alternative, would it be workable to convert this test to use -fsanitize-trap? That way, the test program would trap after issuing a runtime error (it can be run with `not --crash %run ...`).

Yes, that works: by trapping directly at the point of the UB, there's no longer a difference between targets that actually fault and others that don't.  I've kept the `CHECK-STORE` check in place since it's actually nicer/more detailed than just a `SIGILL`.  Once ubsan can handle this case, the original check can be restored.

Again tested on `sparcv9-sun-solaris2.11`, `amd64-pc-solaris2.11`, and `x86_64-pc-linux-gnu`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85433/new/

https://reviews.llvm.org/D85433