[PATCH] D85451: [NFC][MLInliner] Refactor logging implementation

[Yundi Qian via Phabricator via llvm-commits]

yundiqian added inline comments.


================
Comment at: llvm/lib/Analysis/DevelopmentModeInlineAdvisor.cpp:107
+                             const T *TensorData, size_t TensorCount,
+                             Optional<StringRef> LoggingName = None) const {
+    writeRawTensorsAsFeatureLists(OutFile, Spec,
----------------
when we will be using this?


================
Comment at: llvm/lib/Analysis/DevelopmentModeInlineAdvisor.cpp:123-138
+    if (Spec.isElementType<int64_t>()) {
+      FieldName = "int64_list";
+      ValueWriter = [&](const char *Data) {
+        writeTensorValues<int64_t>(OutFile, Data, Spec.getElementCount());
+      };
+    } else if (Spec.isElementType<int32_t>()) {
+      FieldName = "int64_list";
----------------
is it possible to template this as what you did in last two diffs?


================
Comment at: llvm/lib/Analysis/DevelopmentModeInlineAdvisor.cpp:162
+  std::vector<int64_t> Decisions;
   std::vector<bool> Effects;
   std::vector<int64_t> Rewards;
----------------
should Effects also becomes int64_t if Decisions are int64_t?


================
Comment at: llvm/lib/Analysis/DevelopmentModeInlineAdvisor.cpp:382-384
+  writeTensorsAsFeatureLists(OutFile,
+                             TensorSpec::createSpec<int64_t>(DecisionName, {1}),
+                             Decisions.data(), NumberOfRecords);
----------------
shall we log Effect instead of Decision?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85451/new/

https://reviews.llvm.org/D85451