[PATCH] D85414: [test][DebugInfo] Adapt two tests for Sun assembler syntax on Sparc

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

If we're talking about perfection - the best thing to do would be to upgrade these tests to use llvm-dwarfdump instead of raw assembly testing.

If we're talking about just "let's make this work" - is the "section" part consistent on all platforms? Could we extend the check lines to be more like: "# CHECK: .section .debug_info" ? I'm not entirely sure. If we can't easily be sure of the answer to that, I'd probably go with the patch as-is.

Removing the debug_info CHECK line risks these checks matching the abbrev contents, instead of the debug_info contents - which would be a slight regression in the intentions of tnhe test, though probably not a huge one.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85414/new/

https://reviews.llvm.org/D85414