[PATCH] D85081: [lld-macho] Support dynamic linking of thread-locals

[Jez Ng via Phabricator via llvm-commits]

int3 added inline comments.


================
Comment at: lld/MachO/SyntheticSections.h:104
+// that the TLVPointerSection stores references to thread-local variables.
+class NonLazyPointerSection : public SyntheticSection {
 public:
----------------
int3 wrote:
> compnerd wrote:
> > Would you mind renaming this type?  It is confusing with `__nl_symbol_ptr` being a specific section.
> Do you have a suggestion? I picked this name since all these sections will have the `S_NON_LAZY_SYMBOL_POINTERS` flag set. I initially didn't think the collision with `__nl_symbol_ptr` was super important since it no longer seems to be used when linking for x86_64 targets, but I've realized that it's still in use for ARM (and i386) targets
I'm thinking `NonLazyPointerBase` or `NonLazyPointerSectionBase`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85081/new/

https://reviews.llvm.org/D85081