[PATCH] D85373: [llvm][MLInliner] Don't log 'mandatory' events

[Mircea Trofin via Phabricator via llvm-commits]

mtrofin marked an inline comment as done.
mtrofin added inline comments.


================
Comment at: llvm/test/Transforms/Inline/ML/bounds-checks-rewards.ll:21
+; forces no further inlinings.
+; RUN: opt -passes=scc-oz-module-inliner -ml-inliner-ir2native-model=%S/../../../../unittests/Analysis/Inputs/ir2native_x86_64_model -ml-inliner-model-under-training=%S/../../../../lib/Analysis/models/inliner -training-log=- -enable-ml-inliner=development -ml-advisor-size-increase-threshold=1.1 -S < %s 2>&1 | FileCheck %s --check-prefix=CHECK --check-prefix=RELAXED-BOUNDS
 
----------------
MaskRay wrote:
> Note that `%S/../../` is uncommon. This will break our internal lit runner.
Ack - as discussed offline, I would also prefer moving the inputs to the local Inputs dir. For the interim (i.e. until we actually enable this by default in our internal build, for example, or until we move the files), I'll add a comment warning test maintainers about the cross-folder dependency.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85373/new/

https://reviews.llvm.org/D85373