[PATCH] D85337: [AMDGPU] gfx1031 target

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 5 12:35:42 PDT 2020


rampitec added inline comments.


================
Comment at: clang/lib/Basic/Targets/AMDGPU.cpp:178
+    case GK_GFX1031:
     case GK_GFX1030:
       Features["ci-insts"] = true;
----------------
arsenm wrote:
> I would expect 1030 to come first
We always do it like this. The reason is a higher arch can add some features and then we fall-through.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85337/new/

https://reviews.llvm.org/D85337



More information about the llvm-commits mailing list