[PATCH] D85397: [DWARFYAML][debug_info] Make the 'Values' field optional.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 6 02:23:40 PDT 2020


grimar accepted this revision.
grimar added a comment.
This revision is now accepted and ready to land.

LGTM. Though better wait for a second opinion.



================
Comment at: llvm/test/tools/yaml2obj/ELF/DWARF/debug-info.yaml:846
+
+## l) Test that if we don't specify the 'Values' entry, yaml2obj will only emit the abbrev_code.
+
----------------
`the 'Values' entry` -> `the `Values` key for an entry` I guess is more clear.
(At first I thought hat `Values` is a property of `debug_info`.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85397/new/

https://reviews.llvm.org/D85397



More information about the llvm-commits mailing list