[PATCH] D84519: [llvm-objdump][AMDGPU] Detect CPU string

Ronak Chauhan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 6 01:01:55 PDT 2020


rochauha added a comment.

To me, it doesn't look like this is 'real' target-specific work. For example the target triple is detected within llvm-objdump itself using the `getTarget()` function. I'd like to understand - what is different in case CPU string detection that it needs to reside somewhere else?

However, one place that I can think of is the `Object/ELFObjectFile.h`.  There are functions like `getFileFormatName()` and `getArch()`. Perhaps might be reasonable to have a `getCPUNameIfPossible()` too?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84519/new/

https://reviews.llvm.org/D84519



More information about the llvm-commits mailing list