[PATCH] D85394: [NewPM][GuardWidening] Fix loop guard widening tests under NPM

Bjorn Pettersson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 6 00:33:51 PDT 2020


bjope added inline comments.


================
Comment at: llvm/test/Transforms/GuardWidening/loop-schedule.ll:7
 
-; CHECK: Loop Pass Manager
-; CHECK:   Loop Invariant Code Motion
-; CHECK:   Widen guards (within a single loop, as a loop pass)
-; CHECK:   Loop Invariant Code Motion
+; LPM: Loop Pass Manager
+; LPM:   Loop Invariant Code Motion
----------------
Why isn't this checked for NewPM? 
If this is the main point with the test, then the main point verification is missing with NewPM!?!?

Btw, shouldn't it be CHECK-NEXT if one wants to verify that there is nothing between those checked lines.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85394/new/

https://reviews.llvm.org/D85394



More information about the llvm-commits mailing list