[PATCH] D85331: [HotColdSplit] Add options for splitting cold functions in separate section

[Rodrigo Caetano Rocha via Phabricator via llvm-commits]

rcorcs added a comment.

Minor suggestions.



================
Comment at: llvm/lib/Transforms/IPO/HotColdSplitting.cpp:90-91
+    EnableColdSection("enable-cold-section", cl::init(false), cl::Hidden,
+                      cl::desc("Set to true for splitting cold functions into"
+                               " separate cold region."));
+
----------------
Suggested description:
Enable the placement of extracted cold functions into a separate section after hot-cold splitting.


================
Comment at: llvm/lib/Transforms/IPO/HotColdSplitting.cpp:96
+                    cl::Hidden,
+                    cl::desc("Cold section name for section splitting"));
+
----------------
Suggested description:
Name for the section containing cold functions extracted by hot-cold splitting.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85331/new/

https://reviews.llvm.org/D85331