[PATCH] D84825: [release/11.x only][ELF] Change tombstone value -1 to 0

Wed Aug 5 11:38:09 PDT 2020

echristo added a comment.

In D84825#2195429 <https://reviews.llvm.org/D84825#2195429>, @MaskRay wrote:

>> At which point we are at an impasse and the default behavior applies. Please revert completely back to the original behavior immediately.
>>
>> Thanks.
>
> With respect I think the "request for changes" blocked the change and I am not inclined to agree we would otherwise be at an impasse without the "request for changes".
> I would likely get an "Accept Revision" or a just textual "LGTM", even if there is a conditional request that ".debug_* should use 0 as well, like GNU ld". I have mentioned that my position has been weakened. (I made the reply after 5 days, not my usual style as you can tell, because the related threads have caused so much stress/pain to me. I would otherwise not be able to focus on real work. In some sense, I feel that I am fighting a really meaningless battle, even the original proposers have not said something on this patch - Why do I still care about the resolution so much? The all things make me feel I can't really make a fair decision on this patch. I regret that I was involved in the original implementation. I would definitely better if I were just a reviewer)
>
> I sent the patch instead of reverting 3 or 4 intertwined dependent patches because I think reverting will just make the situation more confusing. I have experienced the review processes of all relevant patches and have read all the context,
> so I very responsibly state again that "a simple revert of 3 or 4 dependent patches will just make the situation more confusing".
>
> **I will very appreciate feedback from other people, not my colleague, especially LLD contributors such as @psmith @grimar @jhenderson, whether we really need a flag in this patch or can we simply defer it to another thread.**

With all respect: that we are colleagues is irrelevant here. This is merely a part of how the llvm project works. If we can't reach consensus, and we haven't, with multiple requests from contributors to revert the process is to revert. Please follow that process.

Thanks.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84825/new/

https://reviews.llvm.org/D84825