[PATCH] D85104: [flang][NFC] Unify OpenMP and OpenACC structure checker

Brian Yang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 5 10:50:09 PDT 2020


ichoyjx accepted this revision.
ichoyjx added inline comments.


================
Comment at: flang/lib/Semantics/check-directive-structure.h:30
+
+template <typename D, typename C, typename PC, std::size_t ClauseEnumSize>
+class DirectiveStructureChecker : public virtual BaseChecker {
----------------
Quick question, PC stands for?


================
Comment at: flang/lib/Semantics/check-omp-structure.cpp:43
+
+    CheckMatching<parser::OmpLoopDirective>(beginDir, endDir);
   }
----------------
Adding `CheckMatching` into all the `Enter` functions is a good move.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85104/new/

https://reviews.llvm.org/D85104



More information about the llvm-commits mailing list