[PATCH] D85296: [DWARFYAML][debug_info] Pull out dwarf::FormParams from DWARFYAML::Unit.

Xing GUO via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 5 05:45:56 PDT 2020


Higuoxing created this revision.
Higuoxing added reviewers: labath, jhenderson, grimar, MaskRay.
Herald added subscribers: llvm-commits, hiraditya, aprantl.
Herald added a project: LLVM.
Higuoxing requested review of this revision.

Unit.Format, Unit.Version and Unit.AddrSize are replaced with
dwarf::FormParams in D84496 <https://reviews.llvm.org/D84496> to get rid of unnecessary functions
getOffsetSize() and getRefSize(). However, that change makes it
difficult to make AddrSize optional (Optional<uint8_t>). This change
pulls out dwarf::FormParams from DWARFYAML::Unit and use it as a helper
struct in DWARFYAML::emitDebugInfo().


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D85296

Files:
  llvm/include/llvm/ObjectYAML/DWARFYAML.h
  llvm/lib/ObjectYAML/DWARFEmitter.cpp
  llvm/lib/ObjectYAML/DWARFYAML.cpp
  llvm/tools/obj2yaml/dwarf2yaml.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D85296.283209.patch
Type: text/x-patch
Size: 7290 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200805/dc0ae949/attachment.bin>


More information about the llvm-commits mailing list