[llvm] c558c22 - [llvm-symbolizer] Add legacy aliases -demangle=true and -demangle=false.

[Benjamin Kramer via llvm-commits]

Author: Benjamin Kramer
Date: 2020-08-05T12:07:46+02:00
New Revision: c558c22cab9a555d2e521102b775759381e9727f

URL: https://github.com/llvm/llvm-project/commit/c558c22cab9a555d2e521102b775759381e9727f
DIFF: https://github.com/llvm/llvm-project/commit/c558c22cab9a555d2e521102b775759381e9727f.diff

LOG: [llvm-symbolizer] Add legacy aliases -demangle=true and -demangle=false.

This is used in the wild, don't break compatibility for no good reason.
https://github.com/google/pprof/blob/master/internal/binutils/addr2liner_llvm.go

Added: 
    

Modified: 
    llvm/test/tools/llvm-symbolizer/demangle.s
    llvm/tools/llvm-symbolizer/Opts.td

Removed: 
    


################################################################################
diff  --git a/llvm/test/tools/llvm-symbolizer/demangle.s b/llvm/test/tools/llvm-symbolizer/demangle.s
index 14156bf498d8..f4327bdca7a1 100644
--- a/llvm/test/tools/llvm-symbolizer/demangle.s
+++ b/llvm/test/tools/llvm-symbolizer/demangle.s
@@ -31,5 +31,11 @@ _Z1cv:
 # RUN: llvm-addr2line -fCe %t.o 0 \
 # RUN:    | FileCheck %s --check-prefix=DEMANGLED_FUNCTION_NAME
 
+# pprof passes -demangle=false
+# RUN: llvm-symbolizer -demangle=false --obj %t.o 0 \
+# RUN:    | FileCheck %s --check-prefix=MANGLED_FUNCTION_NAME
+# RUN: llvm-symbolizer -demangle=true --obj %t.o 0 \
+# RUN:    | FileCheck %s --check-prefix=DEMANGLED_FUNCTION_NAME
+
 # MANGLED_FUNCTION_NAME: _Z1cv
 # DEMANGLED_FUNCTION_NAME: c()

diff  --git a/llvm/tools/llvm-symbolizer/Opts.td b/llvm/tools/llvm-symbolizer/Opts.td
index 66b38924023f..8be550983fe2 100644
--- a/llvm/tools/llvm-symbolizer/Opts.td
+++ b/llvm/tools/llvm-symbolizer/Opts.td
@@ -62,3 +62,6 @@ def : Flag<["-"], "s">, Alias<basenames>, HelpText<"Alias for --basenames">;
 // Compatibility aliases for old asan_symbolize.py and sanitizer binaries (before 2020-08).
 def : Flag<["--"], "inlining=true">, Alias<inlines>, HelpText<"Alias for --inlines">;
 def : Flag<["--"], "inlining=false">, Alias<no_inlines>, HelpText<"Alias for --no-inlines">;
+// Compatibility aliases for pprof's symbolizer.
+def : Flag<["-"], "demangle=true">, Alias<demangle>, HelpText<"Alias for --demangle">;
+def : Flag<["-"], "demangle=false">, Alias<no_demangle>, HelpText<"Alias for --no-demangle">;