[PATCH] D84191: [llvm-objdump] Symbolize binary addresses for low-noisy asm diff.

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

Looks good from my point of view, but please wait for @MaskRay.



================
Comment at: llvm/docs/CommandGuide/llvm-objdump.rst:211
+
+.. code-block:: none
+    cmp eax, dword ptr [rip + 4112]
----------------
hoyFB wrote:
> jhenderson wrote:
> > As this is associated with the option, it needs indenting with a couple of spaces, just like the text describing the option. Same goes below. If you take a look at the output, you'll see that adding a couple of spaces before should cause the code to be shifted slightly to the right.
> Done adding indentation.
> 
> BTW, how should I see the the out of the `.rst` file?
You need to set LLVM_ENABLE_SPHINX to on in your CMake configuration and then build the docs-llvm-html target. See https://llvm.org/docs/GettingStarted.html for details. Depending on your system configuration, you might need to install Sphinx and (I think) recommonmark too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84191/new/

https://reviews.llvm.org/D84191