[PATCH] D84825: [release/11.x only][ELF] Change tombstone value -1 to 0

[Eric Christopher via llvm-commits]

On Tue, Aug 4, 2020 at 11:38 PM Eric Christopher <echristo at gmail.com> wrote:

>
>
> On Tue, Aug 4, 2020 at 11:32 PM Fangrui Song via Phabricator <
> reviews at reviews.llvm.org> wrote:
>
>> MaskRay added a comment.
>>
>> > At which point we are at an impasse and the default behavior applies.
>> Please revert completely back to the original behavior immediately.
>> >
>> > Thanks.
>>
>> With respect I think the "request for changes" blocked the change and I
>> am not inclined to agree we would otherwise be at an impasse without the
>> "request for changes".
>> I would likely get an "Accept Revision" or a just textual "LGTM", even if
>> there is a conditional request that ".debug_* should use 0 as well".
>>
>
> Right now it appears that we can agree on a forward direction to make or
> even which behavior to revert to so that means that we need to revert all
> the way.
>
> I sent the patch instead of reverting 3 or 4 dependent patches because I
>> think reverting will just make the situation more confusing. I have
>> experienced the review process and have read all the context,
>> so I very responsibly state again that "a simple revert of 3 or 4
>> dependent patches will just make the situation more confusing".
>>
>
> Sadly it might in the short term make things more confusing, but it gives
> our users a place to start from.
>
> That this thread has gone on so long and currently our users are blocked
> on being able to do anything means we need to go back to a default state
> whether or not that's less convenient for us with changes in behavior.
>
>
To elaborate further: I'm sympathetic to wanting to get the behavior a
little more set, but unfortunately it looks like we haven't been able to
come to agreement on what that behavior is.  My personal thought is to go
with switching to the bfd semantics and maybe fix debug_loc the same way as
debug_ranges to be a bit better than the default bfd semantics.

I think if that direction is ok with you for now then we can go ahead and
make that change otherwise I think we need to reset and try to make a plan
to move forward again.

Thanks and sorry it's so much discussion here :)

-eric
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200804/237f2e10/attachment.html>