[PATCH] D85257: [X86] Optimize getImpliedDisabledFeatures & getImpliedEnabledFeatures'

Tue Aug 4 17:20:53 PDT 2020

craig.topper added a comment.

In D85257#2194993 <https://reviews.llvm.org/D85257#2194993>, @nickdesaulniers wrote:

> In D85257#2194952 <https://reviews.llvm.org/D85257#2194952>, @nickdesaulniers wrote:
>
>> I suspect `setFeatureEnabled` is being called for every global.
>
> Ah, it looks like `clang::Parser::ParseAsmStatement`, so each inline asm statement is problematic.   I guess that's no surprise for the kernel.  There's another call from `ParseAsmStatement` that then calls `clang::targets::X86TargetInfo::initFeatureMap`, but I can't see it (the type signature overflows in `perf report`).

We can probably do something better there if the function doesn't have a target attribute on it.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85257/new/

https://reviews.llvm.org/D85257