[PATCH] D81364: AMDGPU: Correct prolog SP initialization logic

Scott Linder via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 4 14:39:28 PDT 2020


scott.linder added a comment.

I don't know if this has anything to do with David's issue, but I think separately this makes sense. I'm just confused what the semantic difference between the two "do we need an SP" predicates is?



================
Comment at: llvm/lib/Target/AMDGPU/SIFrameLowering.cpp:1295
+
+bool SIFrameLowering::requiresStackPointerReference(const MachineFunction &MF) const {
+  // Callable functions always require a stack pointer reference.
----------------
How does this differ from `frameRequiresSP`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81364/new/

https://reviews.llvm.org/D81364



More information about the llvm-commits mailing list