[PATCH] D85183: [llvm-rc] Allow string table values split into multiple string literals

Adrian McCarthy via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 4 13:47:54 PDT 2020


amccarth accepted this revision.
amccarth added a comment.
This revision is now accepted and ready to land.

OK, makes sense.  I was hoping the processing could happen as you build up the concatenated string rather than at the end.  But now I see the design doesn't really allow for that.

LGTM if you keep `insertStringIntoBundle` singular.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85183/new/

https://reviews.llvm.org/D85183



More information about the llvm-commits mailing list