[PATCH] D85227: [Draft][MSAN] Cache stack traces and chained origins

Gui Andrade via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 4 10:37:43 PDT 2020


guiand added inline comments.


================
Comment at: compiler-rt/lib/msan/msan_origin.h:130
     if (flags()->origin_history_per_stack_limit > 0) {
-      int use_count = h.use_count();
-      if (use_count > flags()->origin_history_per_stack_limit) return prev;
+      // int use_count = h.use_count();
+      // if (use_count > flags()->origin_history_per_stack_limit) return prev;
----------------
I'm only not really sure what to do about these use counts. Updating them in the depot somewhat defeats the purpose of trying to prevent depot accesses through caching.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85227/new/

https://reviews.llvm.org/D85227



More information about the llvm-commits mailing list