[PATCH] D85199: GlobalISel: Add generic instructions for memory intrinsics

Tue Aug 4 06:04:21 PDT 2020

arsenm added a comment.

In D85199#2193230 <https://reviews.llvm.org/D85199#2193230>, @gargaroff wrote:

> Would it be possible to add support for `clampScalar` for the `size_t` argument of these opcodes? Since there is still the problem in the frontend where these intrinsics are created with an incorrect type for the `size_t` argument, I think that would be useful.
> Obviously it would be best to never encounter this case in the backend, but I don't see D76283 <https://reviews.llvm.org/D76283> landing any time soon, so...

It could, but it isn't strictly necessary. The promotion gets inserted in the libcall lowering (and load/store introduced by the future lower action) so it ends up not mattering. It would be more useful if there was a target that had a native memcpy instruction of some kind

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85199/new/

https://reviews.llvm.org/D85199