[PATCH] D85078: [flang] Fix multi-config generator builds

Andrzej Warzynski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 4 04:37:34 PDT 2020


andwar updated this revision to Diff 282864.
andwar added a comment.

- Fixed the LIT config - originally config.flang_standalone_build was a string

(either "ON" or "OFF"), but the canonical LLVM way is to use
llvm_canonicalize_cmake_booleans so that the corresponding LIT variable becomes
numeric 0 or 1

- Added David's original commit message and attributed the patch to him (I'm not

sure whether that will be visible in Phab)

Tested with `-G Ninja` and `-G "Ninja Multi-Config"` for in-tree, and `-G
Ninja` for out-of-tree. `ninja check-all` works fine.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85078/new/

https://reviews.llvm.org/D85078

Files:
  flang/CMakeLists.txt
  flang/test/CMakeLists.txt
  flang/test/lit.cfg.py
  flang/test/lit.site.cfg.py.in
  flang/tools/f18/CMakeLists.txt

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D85078.282864.patch
Type: text/x-patch
Size: 5894 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200804/f0c6db65/attachment.bin>


More information about the llvm-commits mailing list