[PATCH] D85099: [UpdateTestChecks] Match unnamed values like "@[0-9]+" and "![0-9]+"

Stefan Stipanovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 3 14:38:15 PDT 2020


sstefan1 added a comment.

lgtm, apart from clang tests. Someone else should take a look as well, though.



================
Comment at: llvm/utils/UpdateTestChecks/common.py:299
+
+# The prefixes we use in check lines for unamed values and the prefixes we use
+# in IR for these kind of values. The position in these arrays needs to match
----------------
typo: unnamed.


================
Comment at: llvm/utils/UpdateTestChecks/common.py:301
+# in IR for these kind of values. The position in these arrays needs to match
+# the position of the corresponding froup in the IR_VALUE_RE regexp. Appending
+# to these arrays and to the disjunction in the regexp (the middle group with
----------------
typo: group


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85099/new/

https://reviews.llvm.org/D85099



More information about the llvm-commits mailing list