[PATCH] D84043: [AArch64][SVE] Fix CFA calculation in presence of SVE objects.

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 3 13:37:51 PDT 2020


efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.

LGTM with one minor comment



================
Comment at: llvm/lib/Target/AArch64/AArch64FrameLowering.cpp:440
+
+  std::string CommentBuffer = "x31";
+  llvm::raw_string_ostream Comment(CommentBuffer);
----------------
Why "x31" and not "sp"?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84043/new/

https://reviews.llvm.org/D84043



More information about the llvm-commits mailing list