[PATCH] D85079: [lld-macho] Ensure .tbss sections are also considered as ZeroFilled

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: lld/MachO/InputSection.h:39
 inline bool isZeroFill(uint8_t flags) {
-  return (flags & llvm::MachO::SECTION_TYPE) == llvm::MachO::S_ZEROFILL;
+  return llvm::MachO::isVirtualSection(flags & llvm::MachO::SECTION_TYPE);
+}
----------------
int3 wrote:
> MaskRay wrote:
> > If you `using namespace llvm` then you can omit `llvm::`
> I think we should avoid `using namespace` inside header files...
You're right. Did not notice this is a .h......... my bad


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85079/new/

https://reviews.llvm.org/D85079