[PATCH] D84023: Make MSVC generate appropriate __cplusplus macro definition

Tatyana Krasnukha via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 3 04:40:14 PDT 2020


tatyana-krasnukha added a comment.

LLVM documentation says: "You will need Visual Studio 2017 or higher, ** with the latest Update installed**". Does this mean  Visual Studio 2017 version 15.9?

This patch led to multiple warnings on the lldb-x64-windows-ninja buildbot,  which uses Visual Studio 2017 version 15.0, and I don't know whether I should revert the commit or not.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84023/new/

https://reviews.llvm.org/D84023



More information about the llvm-commits mailing list