[PATCH] D85013: [llvm-readobj] - Massive test cases cleanup.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 3 03:22:39 PDT 2020


grimar added inline comments.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/reloc-symbol-with-versioning.test:38-39
     Link:            .dynstr
     AddressAlign:    0x0000000000000004
     Info:            0x0000000000000002
+    Dependencies:
----------------
jhenderson wrote:
> Seems like you should be able to improve this YAML further by removing extra keys/replacing them with direct section name references etc? Same goes with .rela.plt below too.
I was able to simplify the YAML below, but I see nothing I can do for this place.
Note, that "Info" here is a number of dependencies, not a section index.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85013/new/

https://reviews.llvm.org/D85013



More information about the llvm-commits mailing list