[PATCH] D82252: MachO: support `-syslibroot`

Saleem Abdulrasool via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Aug 1 09:37:18 PDT 2020


compnerd marked 5 inline comments as done.
compnerd added inline comments.


================
Comment at: lld/test/MachO/syslibroot.test:14
+
+RUN: mkdir -p %t/Users/compnerd/Library/libxml2-development
+RUN: lld -flavor darwinnew -v -syslibroot %t -L /Users/compnerd/Library/libxml2-development | FileCheck %s -check-prefix CHECK-ABSOLUTE-PATH-REROOTED
----------------
int3 wrote:
> nit: could we have a shorter tmp directory name?
Sure, we can make it a system library path instead.  IMO, the longer path immediately identifies that this is definitely not a default search path (`/System/Library/Frameworks` vs `/Library/Frameworks` is slightly easier to miss).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82252/new/

https://reviews.llvm.org/D82252



More information about the llvm-commits mailing list