[PATCH] D84858: [llvm-libtool-darwin] Refactor ArchiveWriter

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/lib/Object/ArchiveWriter.cpp:650
+                   std::unique_ptr<MemoryBuffer> OldArchiveBuf) {
+
+  Expected<sys::fs::TempFile> Temp =
----------------
Delete the empty line.


================
Comment at: llvm/lib/Object/ArchiveWriter.cpp:660
 
+Error writeArchiveBuffer(StringRef ArcName,
+                         ArrayRef<NewArchiveMember> NewMembers,
----------------
What about changing ReturnBuffer to be the return type `Expected<std::unique_ptr<MemoryBuffer>> `?


================
Comment at: llvm/lib/Object/ArchiveWriter.cpp:666
+                         std::unique_ptr<MemoryBuffer> OldArchiveBuf) {
+
+  Expected<sys::fs::TempFile> Temp =
----------------
Delete the empty line.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84858/new/

https://reviews.llvm.org/D84858