[PATCH] D84022: [flang] Fix multi-config generator builds.

[David Truby via Phabricator via llvm-commits]

DavidTruby added a comment.

In D84022#2188303 <https://reviews.llvm.org/D84022#2188303>, @tskeith wrote:

> In D84022#2188213 <https://reviews.llvm.org/D84022#2188213>, @DavidTruby wrote:
>
>> @tskeith could you explain your rationale for reverting this please? I don't think it's reasonable to expect all patches to be tested with out-of-tree configurations by people that don't perform them, and reverting here seems to raise that expectation.
>
> Out-of-tree builds is a supported configuration, documented in the README. I don't think developers should be expected to test every possible build configuration, but if a change breaks a build and can't be fixed right away it should be reverted.

This is effectively the same as asking everyone to test every build configuration; for example, what should I do now that this revert has broken //my// builds? 
I can either revert the revert, or I am forced to test and fix a build configuration I don't use, which leads to me having to test every possible build configuration. 
The only solution to //not// requiring people to test every build configuration is that the burden of fixing build configurations that aren't defended by buildbots should be the on the person requiring those configurations. Otherwise people de-facto have to build with and fix every configuration someone might care about or have their patch reverted like this one.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84022/new/

https://reviews.llvm.org/D84022