[PATCH] D84959: [NewPM][LVI] Abandon LVI after CVP

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 31 12:51:26 PDT 2020


aeubanks accepted this revision.
aeubanks added a comment.

In D84959#2188060 <https://reviews.llvm.org/D84959#2188060>, @aeubanks wrote:

> I had a random thought, maybe CVP itself shouldn't be invalidating LVI, but rather it should be explicitly invalidated in `PassBuilder::buildFunctionSimplificationPipeline()` with a `InvalidateAnalysisPass<LazyValueAnalysis>`. Since the description mentions that this is based on the knowledge that no passes after CVP will use LVI. ???

I'm not super familiar with the details, but if LVI should really always created on demand then immediately invalidated after CVP, then this lgtm.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84959/new/

https://reviews.llvm.org/D84959



More information about the llvm-commits mailing list