[PATCH] D84347: [MLIR,OpenMP] Lowering of parallel operation: proc_bind clause 2/n

David Truby via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 31 06:28:02 PDT 2020


DavidTruby added inline comments.


================
Comment at: llvm/lib/Frontend/OpenMP/OMPConstants.cpp:29
+
+} // end namespace llvm
----------------
jdoerfert wrote:
> We had a file like this before, I think. We removed it because the content was generated. Maybe this is the time to move the proc bind enum to tablegen?
Personally I think moving proc-bind to tablegen should be a separate patch done either before or after this one, rather than as part of this patch. I agree that it should be done though!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84347/new/

https://reviews.llvm.org/D84347



More information about the llvm-commits mailing list