[PATCH] D84994: [SampleFDO] Fix a crash when the sample profile uses md5 and -sample-profile-merge-inlinee is enabled

Wenlei He via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 30 20:21:56 PDT 2020


wenlei added a subscriber: hoyFB.
wenlei added a comment.

Just realized this is fixing the same issue as @hoyFB's D84997 <https://reviews.llvm.org/D84997> - we ran into it immediately after `-sample-profile-merge-inlinee` is turned on too.

It looks to me that we only need to transfer `GUIDToFuncNameMap` during merge as the map is shared, so it can be done at merge time like D84997 <https://reviews.llvm.org/D84997>. What do you think? That's the fixed we used internally.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84994/new/

https://reviews.llvm.org/D84994



More information about the llvm-commits mailing list