[PATCH] D84980: [Attributor] Add time trace support.

[Kuter Dinel via Phabricator via llvm-commits]

kuter added a comment.

In D84980#2185839 <https://reviews.llvm.org/D84980#2185839>, @jdoerfert wrote:

> Really cool :) LGTM

Ok. As I said in the chat, when we create a attribute we update it once or we can force a update in the query function, Because of this
the time that it takes to do the update gets added to the time of the attribute that triggered it.

The time data we get doesn't accurately represent the amount of compute that the updateAA of a specific attribute does.
since the cost of updating a update when it's first created get's added on top of the time of the attribute that first asked for it.

We can keep track of the update times ourselves, We would stop the timer of the attribute before we start updating another one and restart it when we are done.
We can inject entries directly into the `TimeTraceProfiler` but that would require some changes with it.

I am not sure if we want to go that route, maybe we land this patch like this for now and if we have hard time interpreting this data, we can add that later ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84980/new/

https://reviews.llvm.org/D84980