[PATCH] D84043: [AArch64][SVE] Fix CFA calculation in presence of SVE objects.

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a subscriber: dblaikie.
efriedma added a comment.

I'm not really familiar enough with DWARF expressions to give this a thorough review, but I don't see anything obviously wrong.



================
Comment at: llvm/lib/Target/AArch64/AArch64FrameLowering.cpp:449
+  DefCfaExpr.append(Expr.str());
+  return MCCFIInstruction::createEscape(nullptr, DefCfaExpr.str());
+}
----------------
It seems unfortunate that we have to emit a stream of raw bytes here.  It would be nice if we could at least emit a comment explaining what the bytes are supposed to mean; maybe we could stick a string in MCCFIInstruction?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84043/new/

https://reviews.llvm.org/D84043