[PATCH] D84941: [JumpThreading] Let ProcessImpliedCondition look into freeze instructions

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 30 12:49:21 PDT 2020


efriedma added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/JumpThreading.cpp:1253
+    // If the branch conditions of BB and CurrentPred is the same freeze
+    // instruction, predecessor's branch condition implies FICond.
+    if (!Implication && FICond && isa<FreezeInst>(PBI->getCondition())) {
----------------
Would it make sense to improve isImpliedCondition, instead of manipulating the result here?  (I haven't looked at the other users of isImpliedCondition, but it seems like the sort of thing isImpliedCondition should handle.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84941/new/

https://reviews.llvm.org/D84941



More information about the llvm-commits mailing list