[PATCH] D81647: MIR Statepoint refactoring. Part 3: Spill GC Ptr regs.

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 30 11:30:56 PDT 2020


reames added inline comments.


================
Comment at: llvm/lib/CodeGen/FixupStatepointCallerSaved.cpp:551
       auto PtrInfo = MachinePointerInfo::getFixedStack(MF, FrameIndex);
       auto *MMO = MF.getMachineMemOperand(PtrInfo, MachineMemOperand::MOLoad,
                                           getRegisterSize(TRI, It.first),
----------------
There's an important semantic bug here.  Test case and candidate fix can be found in https://reviews.llvm.org/D84964.

While writing the test case for this, I also stumbled across an unrelated functional bug.  Filed as https://bugs.llvm.org/show_bug.cgi?id=46916


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81647/new/

https://reviews.llvm.org/D81647



More information about the llvm-commits mailing list