[PATCH] D83692: Add first microbenchmarks for matrix types extensions.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 30 11:07:34 PDT 2020


fhahn planned changes to this revision.
fhahn added a comment.

In D83692#2163816 <https://reviews.llvm.org/D83692#2163816>, @SjoerdMeijer wrote:

> Looks decent as an initial commit to me. Two high level questions:
>
> - I haven't looked at these MicroBenchmarks yets in the test-suite, but in general it would be convenient if a benchmarks also does a correctness check. Do you think there would be any value in doing that here? If so, would that easy to add?

Agreed, that would indeed be convenient. Let me change that.

> - In benchmarking, stable numbers are convenient. Since the input is randomly generated, I was wondering if there could be timing differences depending on different inputs? But I guess not here?

I would expect that the difference in the actual FP values would not impact the throughput/latency of floating point units. I don't think there's anything about that in the public Arm Cortex tuning guides. From what I've seen so far on the devices I have access to is that the numbers are relatively stable, although sometimes there are rather large swings for some individual benchmarks (like +100% in runtime for single benchmarks). But my working theory was that this was due to system noise. If there's a real issue, I think we can address it once it appears


Repository:
  rT test-suite

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83692/new/

https://reviews.llvm.org/D83692



More information about the llvm-commits mailing list