[PATCH] D83316: [OpenMPOpt][WIP] Structure for unittests

Jon Chesterfield via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 30 07:06:24 PDT 2020


JonChesterfield added a comment.

I'm not totally sure about this. There's a lot of test setup relative to the test case itself, and I can't work out by reading the test itself what it's checking. What are all the mock classes for?

I'm wondering if we would be better off refactoring the code it intends to test so that it needs less setup.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83316/new/

https://reviews.llvm.org/D83316



More information about the llvm-commits mailing list