[PATCH] D84923: [ARM] Fix so immediates and pc relative checks

Diogo N. Sampaio via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 30 02:18:02 PDT 2020


dnsampaio created this revision.
dnsampaio added reviewers: dmgreen, simonwallis2.
Herald added subscribers: llvm-commits, danielkiss, hiraditya, kristof.beyls.
Herald added a project: LLVM.
dnsampaio requested review of this revision.

ARM Constant Islands would not consider that
pc relative instructions should use offsets
of 8 in ARM and 4 in thumb mode, so the tested
values did not match the values in the code.

Also it would not detect values that could
could not be represented by SO immediates,
breaking only durin the emission of object
files.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D84923

Files:
  llvm/lib/Target/ARM/ARMConstantIslandPass.cpp
  llvm/test/CodeGen/ARM/constant-island-SOImm.mir
  llvm/test/CodeGen/Thumb2/LowOverheadLoops/fast-fp-loops.ll
  llvm/test/CodeGen/Thumb2/mve-gather-increment.ll
  llvm/test/CodeGen/Thumb2/mve-satmul-loops.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D84923.281843.patch
Type: text/x-patch
Size: 24393 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200730/98c51a75/attachment.bin>


More information about the llvm-commits mailing list