[PATCH] D84911: [DWARFYAML] Make the 'Length' field of the address range table optional.

Thu Jul 30 01:02:18 PDT 2020

jhenderson added inline comments.

================
Comment at: llvm/test/tools/yaml2obj/ELF/DWARF/debug-aranges.yaml:514-515
+
+## k) Test that yaml2obj is able to determine the correct length for the address range table
+## if the 'Length' field isn't specified.
+
----------------
Higuoxing wrote:
> jhenderson wrote:
> > You probably need a variation of this test with a different non-default address size (e.g. 8 for a 32-bit object), to show that the length accounts for the right size. Same applies for the segment selector size.
> Currently, yaml2obj doesn't support emitting the segment selector for the address range table. Shall I implement it before this patch?
No need to do it before unless you want to (this patch is more useful). You can add it afterwards - just make sure to fix this code path when you do!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84911/new/

https://reviews.llvm.org/D84911