[llvm] 1759744 - [X86] Don't pass some many parameters to ParseMemOperand by reference.

[Craig Topper via llvm-commits]

Author: Craig Topper
Date: 2020-07-29T23:44:56-07:00
New Revision: 17597442db159829dd167abb638b198ad0afc309

URL: https://github.com/llvm/llvm-project/commit/17597442db159829dd167abb638b198ad0afc309
DIFF: https://github.com/llvm/llvm-project/commit/17597442db159829dd167abb638b198ad0afc309.diff

LOG: [X86] Don't pass some many parameters to ParseMemOperand by reference.

Pointers and SMLocs are cheap to copy. Even though the function
modifies some of these the caller doesn't use them after the call.

Added: 
    

Modified: 
    llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp b/llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp
index 445bb482055c..0479db857a87 100644
--- a/llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp
+++ b/llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp
@@ -926,9 +926,9 @@ class X86AsmParser : public MCTargetAsmParser {
                                      bool IsParsingOffsetOperator = false);
 
   std::unique_ptr<X86Operand> ParseMemOperand(unsigned SegReg,
-                                              const MCExpr *&Disp,
-                                              const SMLoc &StartLoc,
-                                              SMLoc &EndLoc);
+                                              const MCExpr *Disp,
+                                              SMLoc StartLoc,
+                                              SMLoc EndLoc);
 
   X86::CondCode ParseConditionCode(StringRef CCode);
 
@@ -2418,9 +2418,9 @@ bool X86AsmParser::HandleAVX512Operand(OperandVector &Operands) {
 /// ParseMemOperand: 'seg : disp(basereg, indexreg, scale)'.  The '%ds:' prefix
 /// has already been parsed if present. disp may be provided as well.
 std::unique_ptr<X86Operand> X86AsmParser::ParseMemOperand(unsigned SegReg,
-                                                          const MCExpr *&Disp,
-                                                          const SMLoc &StartLoc,
-                                                          SMLoc &EndLoc) {
+                                                          const MCExpr *Disp,
+                                                          SMLoc StartLoc,
+                                                          SMLoc EndLoc) {
   MCAsmParser &Parser = getParser();
   SMLoc Loc;
   // Based on the initial passed values, we may be in any of these cases, we are