[PATCH] D84896: [MC] Add createMCInst() using a typed MCInst bump allocator.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 29 21:44:38 PDT 2020


MaskRay added a comment.

> Add createMCInst() using a typed MCInst bump allocator.

For titles most patches don't add a full stop. The important fact (it fixes a memory leak) should be mentioned.

> This fixes https://bugs.llvm.org/show_bug.cgi?id=46900.

Add a little detail beside the bug reference about the memory leak.



================
Comment at: llvm/include/llvm/MC/MCContext.h:384
 
+    /// \name McInst Management
+    /// @{
----------------
I think @`{` is used very rarely for new code. You may delete it which does not add any documentation value.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84896/new/

https://reviews.llvm.org/D84896



More information about the llvm-commits mailing list