[PATCH] D84895: [X86] Teach the assembler parser to handle a '*' between segment register and base/index/displacement part of an address

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 29 16:15:07 PDT 2020


MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

Thanks! I followed the control flow in the debugger. It looks good.
Do you have idea what we need to do with `.arch`? For the use of `purgatory/arch/i386/entry32-16.S`, maybe we can just ignore the directive for now?



================
Comment at: llvm/test/MC/X86/x86-64.s:1904
+
+// CHECK: ljmpl *%cs:305419896
+// CHECK:  encoding: [0x2e,0xff,0x2c,0x25,0x78,0x56,0x34,0x12]
----------------
This can be placed near line 400 where other ljmpl tests reside.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84895/new/

https://reviews.llvm.org/D84895



More information about the llvm-commits mailing list