[PATCH] D84570: [tsan] Fix the open and open64 interceptors to have correct declarations (variadic functions)

[Kuba (Brecka) Mracek via Phabricator via llvm-commits]

kubamracek added inline comments.


================
Comment at: compiler-rt/test/tsan/Darwin/variadic-open.cpp:12
+  unlink(argv[1]);
+  int fd = open(argv[1], O_RDWR | O_CREAT, 0644);
+  assert(fd != -1);
----------------
vitalybuka wrote:
> somehow on linux even if file has 644 and argument is 644
> fstat below returns 640
> 
> 
> 
Is that just a umask effect? Would a call to umask(0) help here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84570/new/

https://reviews.llvm.org/D84570