[PATCH] D84879: [X86] Separate CPU Feature lists in X86.td between architecture features and tuning features

Wed Jul 29 11:29:17 PDT 2020

craig.topper created this revision.
craig.topper added reviewers: RKSimon, spatel, echristo.
Herald added subscribers: jfb, hiraditya.
Herald added a project: LLVM.
craig.topper requested review of this revision.

After the recent change to the tuning settings for pentium4 to improve our default 32-bit behavior, I've decided to see about implementing -mtune support. This way we could have a default architecture CPU of "pentium4" or "x86-64" and a default tuning cpu of "generic". And we could change our "pentium4" tuning settings back to what they were before.

As a step to supporting this, this patch separates all of the features lists for the CPUs into 2 lists. I'm using the Proc class and a new ProcModel class to concat the 2 lists before passing to the target independent ProcessorModel. Future work to truly support mtune would change ProcessorModel to take 2 lists separately. I've diffed the X86GenSubtargetInfo.inc file before and after this patch to ensure that the final feature list for the CPUs isn't changed.

https://reviews.llvm.org/D84879

Files:
  llvm/lib/Target/X86/X86.td

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D84879.281681.patch
Type: text/x-patch
Size: 58890 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200729/ed23836d/attachment.bin>