[PATCH] D84729: [PowerPC] Set hasSideEffects for MFFS and MTFSF

Qing Shan Zhang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 28 19:52:39 PDT 2020


steven.zhang added a comment.

Please adding a scheduling test(i.e. checking the dependency between MFFS and floating operations) to show your change fixing what you want.



================
Comment at: llvm/lib/Target/PowerPC/PPCInstrInfo.td:2936
 let Uses = [RM] in {
+  let hasSideEffects = 1 in
   def MFFS   : XForm_42<63, 583, (outs f8rc:$rT), (ins),
----------------
Please add necessary comments here to indicate why we want to set this flag for the read instr.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84729/new/

https://reviews.llvm.org/D84729



More information about the llvm-commits mailing list