[PATCH] D84153: AMDGPU: Relax restriction on folding immediates into physregs

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 28 16:31:06 PDT 2020


rampitec added a comment.

It can probably create a worse code sometimes. Assume you have a constant which cannot be directly assigned to a register (v_accvgpr_write_b32 only accepts inline literals). If source def will not become dead it will create an extra copy. You probably need some legality checks here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84153/new/

https://reviews.llvm.org/D84153



More information about the llvm-commits mailing list