[PATCH] D81364: AMDGPU Initializes StackPtrOffset when NonSpillStackObjects present

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 28 16:20:56 PDT 2020


arsenm updated this revision to Diff 281408.
arsenm added a comment.

Correct the logic.

hasFP || hasCalls should be slightly too conservative. I have no idea what other problem you could have been seeing from using hasFP without a testcase


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81364/new/

https://reviews.llvm.org/D81364

Files:
  llvm/lib/Target/AMDGPU/SIFrameLowering.cpp
  llvm/lib/Target/AMDGPU/SIFrameLowering.h
  llvm/test/CodeGen/AMDGPU/GlobalISel/dynamic-alloca-uniform.ll
  llvm/test/CodeGen/AMDGPU/GlobalISel/non-entry-alloca.ll
  llvm/test/CodeGen/AMDGPU/non-entry-alloca.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D81364.281408.patch
Type: text/x-patch
Size: 6827 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200728/97f2b3b1/attachment.bin>


More information about the llvm-commits mailing list