[PATCH] D84803: [ThinLTO][MachO] Preserve both possible GUIDs from exported list

Steven Wu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 28 14:42:02 PDT 2020


steven_wu added a comment.

This is basically a fundamental issues in GUID for machO format, which I am not sure if we can fix the underlying issue. That requires computing GUID based on mangled name, which can be more expensive and I am not sure if it will break the module summary for compatibility if we switch algorithm. So I fixed the export/preserve list only because that is the only thing I can think of that will surface as a bug. Otherwise, the mismatch GUID will just be a missed optimization opportunity.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84803/new/

https://reviews.llvm.org/D84803



More information about the llvm-commits mailing list